-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review 'reserved' field in header.rs for improved compatibility #137
Labels
Comments
To be compatibile with previous library, the reserved field length need to be a 2 bytes len |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The current Header.rs implementation includes a 'reserved' data field with 2 bytes reserved for future use. While reserving space for future use is acceptable, concerns have been raised regarding the following aspects:
Possible solution design or implementation
The initial rationale behind the 2-byte reservation was to provide flexibility for users to parse the second byte based on changes to the first byte. However, valid concerns have been raised about potential parsing issues for new messages in old versions. To address this, we propose the following solution:
Additional context
This adjustment aims to maintain compatibility during upgrades, ensuring that even older versions can parse the header without fully understanding the content of reserved fields.
The text was updated successfully, but these errors were encountered: