noop(cleanup) dedup w/factored-out (dtinit#1392) counter #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm fixing a bug here where the implementation of the microsoft adapter
was reading an arbitrary stream into memory (using DataChunk class), and
instead "just stream directly to the endpoint". It's not _quite_ that
simple though: we actually stream twice, for the very reason that the
old implementation was streaming into memory: we need to know the
filesize.
while we're here I'm doing some "leave the campground better" tasks, so
here's a more nitty-gritty breakdown of this PR:
- microsoft adapter: marking duplicated code Microsoft{Photo,Video}* as
needing to rely on newly refactored MicrosoftMedia (so hese kinds of
bug fixes are easier to maintain, for example).
- DTP: make testability (via DI) easier with for java.net.URL streamers
(this has already become a pattern, so I just formalized it and
dropped a TODO in the places that are doing this locally; this way, in
the future it'll be easier/more obvious what "the pattern" is and how
to stop maintaining disparate copies of it)
- microsoft adapter: remainder of DataChunk code is now just a POJO, so
switching to autovalue and letting the test live in the primary user:
the new `StreamChunker` (as a mini "integrated" test).
- microsoft adapter: all size-related operations are a `long` now
this utilizes the newly factored out streaming counter, so _should_ be noop.
jzacsh
changed the title
jzacsh
changed the title
seehamrun
approved these changes
Nov 19, 2024
|
just realized there's already unit tests for this ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this utilizes the newly factored out (#1392) streaming counter, so should be noop.