-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecordBase.__init__ slows down #55
Comments
Thanks for noting the comment and letting us know. Of course a PR would be welcome! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
fitparse uses many many objects and many of them are of
RecordBase
, TheRecordBase.__init__
is a bit slow. E.g. I've tried to optimizeFieldData.__init__
:And parsing of
event_timestamp.fit
has sped up by 0.8 sec. Generally, thegetattr
,hasattr
andsetattr
slows down the process when used so extensively.I may create PR to change all
RecordBase
and descendants init. But there's a remark in therecords.py
:Note: Also, the
processor.py
usesgetattr
, extensivelly.The text was updated successfully, but these errors were encountered: