Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Support for setting point_weight_flag and obtype_as_group_val_flag in PointStat and EnsembleStat #2727

Closed
24 tasks
georgemccabe opened this issue Oct 14, 2024 · 0 comments · Fixed by #2730
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Oct 14, 2024

dtcenter/MET#2279 added a new point_weight_flag config variable that should be supported in METplus wrappers.
dtcenter/MET#2893 added a new obtype_as_group_val_flag boolean config variable that should be supported in the METplus wrappers.

Both of these options should be added at the highest level of config file context to both the PointStat and EnsembleStat wrappers.

Describe the Enhancement

Provide a description of the enhancement request here.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone labels Oct 14, 2024
@georgemccabe georgemccabe added this to the METplus-6.0.0 milestone Oct 14, 2024
@georgemccabe georgemccabe self-assigned this Oct 14, 2024
@JohnHalleyGotway JohnHalleyGotway changed the title Enhancement: Add support for setting point_weight_flag in PointStat and EnsembleStat Enhancement: Add support for setting point_weight_flag and obtype_as_group_val_flag in PointStat and EnsembleStat Oct 15, 2024
@georgemccabe georgemccabe linked a pull request Oct 15, 2024 that will close this issue
16 tasks
georgemccabe added a commit that referenced this issue Oct 16, 2024
* Per #2727, add support for setting point_weight_flag

* Per #2727, add support for obtype_as_group_val_flag

* per #2714, deprecate master_metplus.py
@georgemccabe georgemccabe changed the title Enhancement: Add support for setting point_weight_flag and obtype_as_group_val_flag in PointStat and EnsembleStat Enhancement: Support for setting point_weight_flag and obtype_as_group_val_flag in PointStat and EnsembleStat Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant