Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add expand_string logic similar to begin_end_incr #2619

Open
24 tasks
georgemccabe opened this issue Jun 21, 2024 · 0 comments
Open
24 tasks

Enhancement: Add expand_string logic similar to begin_end_incr #2619

georgemccabe opened this issue Jun 21, 2024 · 0 comments
Assignees
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: medium Medium Priority type: enhancement Improve something that it is currently doing

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jun 21, 2024

The begin_end_incr syntax can be used to expand a METplus config value into a list by a list of numbers. For example:

LEAD_SEQ = begin_end_incr(0,45,15)M

expands to

LEAD_SEQ = 0M, 15M, 30M, 45M

Describe the Enhancement

Add support for an expand_string function that can be used to expand out a list of string. For example:

POINT_STAT_MASK_POLY = /some/path/for/my/stations/expand_string(DENVER,MINNEAPOLIS,HOUSTON).nc

will expand to

POINT_STAT_MASK_POLY =
  /some/path/for/my/stations/DENVER.nc,
  /some/path/for/my/stations/MINNEAPOLIS.nc,
  /some/path/for/my/stations/HOUSTON.nc

Time Estimate

1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a METplus-Wrappers-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a METplus-Wrappers-X.Y.Z version, select the METplus-Wrappers-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required priority: medium Medium Priority type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

1 participant