Bugfix: Resolve testing that causes imutils to be imported #471
Labels
component: external dependency
External dependency issue
component: testing
Software testing issue
priority: blocker
Blocker
reporting: DTC NOAA BASE
NOAA Office of Atmospheric Research DTC Project
requestor: NOAA/EMC
NOAA Environmental Modeling Center
required: FOR DEVELOPMENT RELEASE
Required to be completed in the development release for the assigned project
type: bug
Fix something that is not working
Milestone
Describe the Problem
When running test/run_all_nco.sh or test/pythest on WCOSS2, the code errors out with:
These failures were not present in the beta5 installation, and 'imutils' is not allowed on WCOSS2.
It appears this situation came about from this PR Feature 461 make compare images configurable #467 where the line "from metcalcpy.compare_images import CompareImages" was uncommented from approximately 20 files. CompareImages in METcalcpy imports 'imutils'. It looks like the PR intended to make the use of CompareImages configurable by an environment variable used in conftest.py. But, conftest.py is not what is used to test on WCOSS2, instead run_all_nco.sh is used. However, when running pytest the 'imutils' errors are still present.
I'm not sure what the best solution is. It would be good to have a configurable option so that the CompareImages isn't called on WCOSS2, but could be elsewhere if desired.
Expected Behavior
The tests should not utilize code that imports 'imutils'.
Environment
Describe your runtime environment:
1. Machine: Acorn, WCOSS2 test machine
2. OS: SUSE Linux Enterprise Server 15 SP4
3. METplotpy-3.0.0-beta6
To Reproduce
Describe the steps to reproduce the behavior:
Run test/pytest or test/run_all_nco.sh
Relevant Deadlines
RC1 release
Funding Source
2782544 NOAA Base
Define the Metadata
Assignee
Labels
Milestone and Projects###
Define Related Issue(s)##
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
Branch name:
bugfix_<Issue Number>_main_<Version>_<Description>
Pull request:
bugfix <Issue Number> main_<Version> <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next bugfix version
Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
Branch name:
bugfix_<Issue Number>_develop_<Description>
Pull request:
bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: METplotpy-X.Y.Z Development project for development toward the next official release
The text was updated successfully, but these errors were encountered: