Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Resolve testing that causes imutils to be imported #471

Open
9 of 24 tasks
jprestop opened this issue Oct 30, 2024 · 1 comment
Open
9 of 24 tasks

Bugfix: Resolve testing that causes imutils to be imported #471

jprestop opened this issue Oct 30, 2024 · 1 comment
Assignees
Labels
component: external dependency External dependency issue component: testing Software testing issue priority: blocker Blocker reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: bug Fix something that is not working

Comments

@jprestop
Copy link
Contributor

jprestop commented Oct 30, 2024

Describe the Problem

When running test/run_all_nco.sh or test/pythest on WCOSS2, the code errors out with:

ModuleNotFoundError: No module named 'imutils'

These failures were not present in the beta5 installation, and 'imutils' is not allowed on WCOSS2.

It appears this situation came about from this PR Feature 461 make compare images configurable #467 where the line "from metcalcpy.compare_images import CompareImages" was uncommented from approximately 20 files. CompareImages in METcalcpy imports 'imutils'. It looks like the PR intended to make the use of CompareImages configurable by an environment variable used in conftest.py. But, conftest.py is not what is used to test on WCOSS2, instead run_all_nco.sh is used. However, when running pytest the 'imutils' errors are still present.

I'm not sure what the best solution is. It would be good to have a configurable option so that the CompareImages isn't called on WCOSS2, but could be elsewhere if desired.

Expected Behavior

The tests should not utilize code that imports 'imutils'.

Environment

Describe your runtime environment:
1. Machine: Acorn, WCOSS2 test machine
2. OS: SUSE Linux Enterprise Server 15 SP4
3. METplotpy-3.0.0-beta6

To Reproduce

Describe the steps to reproduce the behavior:
Run test/pytest or test/run_all_nco.sh

Relevant Deadlines

RC1 release

Funding Source

2782544 NOAA Base

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects###

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select METplotpy-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)##

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METplotpy-X.Y.Z Development project for development toward the next official release
  • Close this issue.
@jprestop jprestop added type: bug Fix something that is not working priority: blocker Blocker requestor: NOAA/EMC NOAA Environmental Modeling Center alert: NEED ACCOUNT KEY Need to assign an account key to this issue component: external dependency External dependency issue component: testing Software testing issue reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project labels Oct 30, 2024
@jprestop jprestop added this to the METplotpy-3.0.0 milestone Oct 30, 2024
@michelleharrold michelleharrold removed the alert: NEED ACCOUNT KEY Need to assign an account key to this issue label Oct 30, 2024
@michelleharrold
Copy link

@jprestop @bikegeek @georgemccabe -- I added an account key per Julie's request (thanks, Julie!). If the work begins to take too much bandwidth/time, please check back in, so we can reassess the plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: external dependency External dependency issue component: testing Software testing issue priority: blocker Blocker reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR DEVELOPMENT RELEASE Required to be completed in the development release for the assigned project type: bug Fix something that is not working
Projects
Status: 🟢 Ready
Development

No branches or pull requests

3 participants