Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine if ordering of independent variable labels is correct in remaining plots #337

Open
7 of 21 tasks
bikegeek opened this issue Apr 7, 2023 · 3 comments
Open
7 of 21 tasks

Determine if ordering of independent variable labels is correct in remaining plots #337

bikegeek opened this issue Apr 7, 2023 · 3 comments
Assignees
@bikegeek
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplotpy: Plots priority: medium Medium Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Milestone
METplotpy-3.1.0

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Apr 7, 2023 •
edited
Loading

Describe the Task

From issue # 218, go through the remaining plots and ensure that independent labels ordering is maintained for threshold values. This has been found in bar plots, investigate the remaining plots (used by METviewer) to ensure that the same fix is implemented. For reference, please see:
(#218)

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
1-3 days for each plot, based on obtaining or creating data, making the modifications, and testing the modifications.

Sub-Issues

Consider breaking the task down into sub-issues.
Affected plots:

  • Line plot

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) Minna Win
  • Select scientist(s) No scientist

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Task Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: task An actionable item of work priority: high High Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METplotpy: Plots labels Apr 7, 2023
@bikegeek bikegeek added this to the METplotpy-2.1.0 milestone Apr 7, 2023
bikegeek added a commit that referenced this issue Apr 20, 2023
@bikegeek
Issu #337 initial version of skew T, hard-coded, proof-of-concept ver…
d589d7c 
…sion
bikegeek added a commit that referenced this issue Apr 20, 2023
@bikegeek
Issue #337 added support to get the YYMMDDhh and basin-storm id from …
03c476e 
…the input file
bikegeek added a commit that referenced this issue Apr 26, 2023
@bikegeek
Issue #337 added logging support
af4d08d
bikegeek added a commit that referenced this issue Apr 26, 2023
@bikegeek
Issue #337 added settings for logging, decimation, turning on/off plo…
c13a6a2 
…tting features.
bikegeek added a commit that referenced this issue Apr 27, 2023
@bikegeek
Issue #337 updated logging
7c16880
@bikegeek
Copy link
Collaborator Author

bikegeek commented May 5, 2023

For box plot:

  1. generated threshold data using METviewer and the mv_tatiana database:
  • ACPC_12, BASER, BCMSE, FBAR, FAR
  • MODEL, WRF
  • OBS_THRESH, selected
  1. Updated the yaml file
    Box plot handles the OBS_THRESH indy_labels properly, no need to make modifications.

bikegeek added a commit that referenced this issue Jun 13, 2023
@bikegeek @jvigh
Feature 339 tcdiag skewt (#352)
2c565e1 
* Issu #337 initial version of skew T, hard-coded, proof-of-concept version

* initial commit of config file

* Addes some logic to retrieve units for each field.  Still need to get the units for the levels (z).

* Added a few more settings for setting sounding hours of interest.

* Issue #337 added support to get the YYMMDDhh and basin-storm id from the input file

* Issue #337 added logging support

* Issue #337 added settings for logging, decimation, turning on/off plotting features.

* Issue #337 updated logging

* instructions and environment yaml file

* Remove hard-coded paths

* reinstated resampling/decimating wind barbs

* fix comment for labels along the y2-axis

* Close figure after saving to prevent warning from Matplotlib about too many figures opened at once

* allow user to specify subdir for log and output dirs

* Added a note to the README about which line options are supported, as per the error message I recieved when I used an unsupported value (I didn't see the explanation in the config file at first)  -- if not all of these values are actually appropriate, adjust this message as needed.

* updated year for copyright, reformatted file, fixed typos

* tests for partially and completely missing data

* partial and completely missing data to use for testing

* config file for testing

* checking for missing data

---------

Co-authored-by: Jonathan Vigh <[email protected]>
@bikegeek
Copy link
Collaborator Author

bikegeek commented Jun 16, 2023 •
edited
Loading

Unaffected plots:
mpr plot
performance diagram
ROC diagram
wind rose diagram
Taylor diagram
polar plot
mjo_rmm
mjo_enso
spacetime plots
stratosphere diagnostics
hovmoeller
tc-rmw

@bikegeek
Copy link
Collaborator Author

Plots that already correctly handle obs_thresh data:

bar plot

bikegeek added a commit that referenced this issue Jul 11, 2023
@bikegeek @jvigh
Feature 339 tcdiag skewt (#365)
6280c79 
* Issu #337 initial version of skew T, hard-coded, proof-of-concept version

* initial commit of config file

* Addes some logic to retrieve units for each field.  Still need to get the units for the levels (z).

* Added a few more settings for setting sounding hours of interest.

* Issue #337 added support to get the YYMMDDhh and basin-storm id from the input file

* Issue #337 added logging support

* Issue #337 added settings for logging, decimation, turning on/off plotting features.

* Issue #337 updated logging

* instructions and environment yaml file

* Remove hard-coded paths

* reinstated resampling/decimating wind barbs

* fix comment for labels along the y2-axis

* Close figure after saving to prevent warning from Matplotlib about too many figures opened at once

* allow user to specify subdir for log and output dirs

* Added a note to the README about which line options are supported, as per the error message I recieved when I used an unsupported value (I didn't see the explanation in the config file at first)  -- if not all of these values are actually appropriate, adjust this message as needed.

* updated year for copyright, reformatted file, fixed typos

* tests for partially and completely missing data

* partial and completely missing data to use for testing

* config file for testing

* checking for missing data

* Add check for empty file

* Update requirements.txt

update scipy from 1.9.3 to 1.10.0 to address dependabot/vulnerability

* clean up code following sonarlint check

* resolve conflict

* fixed indentation of 'return'- previously got indented too far and only processes the first sounding time

* new data to test behavior when there is an empty file

* Clean up tests, add test for empty input data file

---------

Co-authored-by: Jonathan Vigh <[email protected]>
@bikegeek bikegeek changed the title Provide support for correct ordering of independent variable labels in plots Determine if ordering of independent variable labels is correct in remaining plots Sep 18, 2023
@bikegeek bikegeek added priority: medium Medium Priority and removed priority: high High Priority labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bikegeek bikegeek

Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue METplotpy: Plots priority: medium Medium Priority requestor: METplus Team METplus Development Team required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: task An actionable item of work
Projects
METplus-Analysis-6.1.0 Development
Status: 📖 Backlog
Milestone
METplotpy-3.1.0
Development

When branches are created from issues, their pull requests are automatically linked.

337_ordering_independent_vars dtcenter/METplotpy
2 participants
@bikegeek @TatianaBurek