Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide aggregation support for rank histogram line type RHIST #343

Open
22 tasks
bikegeek opened this issue Dec 13, 2023 · 0 comments
Open
22 tasks

Provide aggregation support for rank histogram line type RHIST #343

bikegeek opened this issue Dec 13, 2023 · 0 comments
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: enhancement Improve something that it is currently doing

Comments

@bikegeek
Copy link
Collaborator

Describe the Enhancement

The RHIST line type from the MET tool ensemble-stat requires support for aggregating, by following the logic in the original R script:

For ranked histogram, it looks like after the optional event equalization is performed, the sum is calculated in this code:
(line 103 rhist.R_tmpl)

#calculate sum
sum_by = list(i_value=dfData$i_value);
columns = c("i_value")
for(seriesVal in names(listSeries1Val)){
  sum_by[seriesVal]=dfData[seriesVal]
  columns = c(columns, seriesVal)
}
columns = c(columns, "stat_value")
dfData=setNames(aggregate(x=dfData$rank_i, by=sum_by, FUN=sum), columns)

found in the METviewer repository:
https://github.com/dtcenter/METviewer/blob/main_v5.1/R_tmpl/rhist.R_tmpl

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Dec 13, 2023
@bikegeek bikegeek assigned bikegeek and hankenstein2 and unassigned bikegeek Dec 13, 2023
@bikegeek bikegeek changed the title Provide aggregation support for rank histogram Provide aggregation support for rank histogram line type RHIST Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required type: enhancement Improve something that it is currently doing
Projects
None yet
Development

No branches or pull requests

2 participants