Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to be more thorough #24

Open
kdheepak opened this issue Aug 15, 2018 · 3 comments
Open

Update tests to be more thorough #24

kdheepak opened this issue Aug 15, 2018 · 3 comments

Comments

@kdheepak
Copy link
Member

kdheepak commented Aug 15, 2018

I'm submitting a ...

  • feature request

Feature Request

Update tests so that they are more complete

e.g. some tests need params

assert dss.Bus.GetUniqueNodeNumber()
assert dss.Circuit.Capacity()
assert dss.Circuit.SetActiveBusi()
assert dss.CktElement.Close()
assert dss.CktElement.IsOpen()
assert dss.CktElement.Open()
assert dss.CktElement.Variablei()
@PMeira
Copy link
Member

PMeira commented Aug 17, 2018

Monitors also need more tests. Probably adding one or two monitors via run_command() in https://github.com/NREL/OpenDSSDirect.py/blob/30a2060ef1b6986be3a80a49a5b474951d994109/tests/test_opendssdirect.py#L1965 and validating the results is enough.

@kdheepak
Copy link
Member Author

Note for future reference: See issue #29 and PR #30 to identify many functions that are not currently tested.

@PMeira
Copy link
Member

PMeira commented Jul 16, 2022

The new modules Parallel and Storages are missing tests now, as well as some recent other new functions in other modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants