Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hugo website to work on v0.135.0 #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Gijsreyn
Copy link

@Gijsreyn Gijsreyn commented Oct 5, 2024

Fix #219


This change is Reviewable

@johlju
Copy link
Member

johlju commented Oct 5, 2024

Tested this on v0.135.0 and looking at Maintainers Gael's info is wrongly on all the maintainers.

@johlju johlju added the waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author. label Oct 5, 2024
@Gijsreyn
Copy link
Author

@johlju Hey Johan, I saw your post on Discord, but couldn't fully grasp the point. Can you explain what you want me to fix, please?

@johlju
Copy link
Member

johlju commented Oct 10, 2024

If you run the site locally you will se that your change make one persons information being shown for all the maintainers instead of their individual information.

It is probably the change in maintainers.html that does it.

@Gijsreyn
Copy link
Author

@johlju Should be fixed! Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for code fix A review left open comments, and the pull request is waiting for changes to be pushed by the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Hugo build on v0.135.0
2 participants