Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tasks skipping if PlatyPS is not available #150

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

johlju
Copy link
Member

@johlju johlju commented Jun 3, 2024

Pull Request (PR) description

  • Generate_Markdown_For_Public_Commands.build
    • Now the task will skip if PlatyPS is not available.
      Generate_External_Help_File_For_Public_Commands
    • Now the task will skip if PlatyPS is not available.

This Pull Request (PR) fixes the following issues

None. Helps with PR SynEdgy/Sampler.DscPipeline#33.

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 89fb1ea into dsccommunity:main Jun 3, 2024
10 checks passed
@johlju johlju deleted the fix/task-throw branch June 3, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant