-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add format: 'webp'
to support Astro automatically.
#13
Comments
format: '.webp'
to support Astro automatically.format: 'webp'
to support Astro automatically.
this is so specific it probably doesn't even matter, i'm just thinking about people less familiar with TypeScript or web development |
That’s a great suggestion! Would love a PR if you’re able to add one. No worries if not though! |
will do!!! |
Oh I see; it’s because |
hi, sorry for late reply. it wouldn't matter in this specific use case as either this or I don't mind adding it, but the PR name should be changed from: to something like |
Ah I think we’re probably touching on some confusion on how this should be used in Astro, which should probably be part of the docs. All LQIP images are That said, I think it’s better to just have an example that makes it easy to use in Astro so people can just copy–paste an example and It Just Works™. I’ll be working on an Astro project next month that will use this plugin again (had a gap between the last Astro project; I used it before the |
Ahh I see what you're saying. This isn't a huge pain point but documenting it somewhere would be 👍🏼 would you like me to add an use with Astro example to the readme? A small section under |
Description
Hello, first I want to say thank you for making this amazing package! this is exactly what I was looking for!
I have absolutely no complaints but wanted to suggest something to see if you would be interested in adding this to your package.
I am using Astro with this plugin and Astro's image component requires the props
src
,width
,height
, andformat
. using your plugin with?lqip
,lqip
is of course added but format is left behind. this is far from the end of the world as the solution i have been using (pictured above) works lovely.with that being said, I don't think it would neccesarily be a bad idea to pass to output the format even though it's just going to be
webp
everytime, so that it automatically satisfies Astro'sImageMetadata
type, and becomes even more out-the-box for those users.Please let me know what thoughts you have on this! and once again this package is easy to use and convenient! thank you so much!
The text was updated successfully, but these errors were encountered: