Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler is called via Celery even if no notification will be created #12

Open
rubickcz opened this issue Apr 16, 2019 · 0 comments
Open

Comments

@rubickcz
Copy link
Member

This is perfomace issue with AsynchronousReceiver. It calls handler via Celery, even if _can_handle() returns False, i.e. when no notification will be created. If _can_handle() is used to filter out a lot of signals sent at once, there is a non-negligible overhead, causing notifications to be created slowly.

A proposed solution is to evaluate result of _can_handle() method inside the receiver, prior to calling handler's handle() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant