Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do you check type and raise error here??? #272

Open
nguyenminhduc9988 opened this issue Sep 7, 2021 · 0 comments
Open

Why do you check type and raise error here??? #272

nguyenminhduc9988 opened this issue Sep 7, 2021 · 0 comments
Assignees

Comments

@nguyenminhduc9988
Copy link

nguyenminhduc9988 commented Sep 7, 2021

Everything that has problem should be return as a String, this client cannot control Druid returned data right, so just return a string to caller, the query succeeded.

The caller has the right to get the result if the query has already been return from Druid. He can make further processing. Why hamper the result with this check?

Screenshot from 2021-09-07 19-06-13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants