Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth input/output not working #2

Open
nitanmarcel opened this issue Dec 7, 2022 · 0 comments
Open

Bluetooth input/output not working #2

nitanmarcel opened this issue Dec 7, 2022 · 0 comments

Comments

@nitanmarcel
Copy link
Contributor

nitanmarcel commented Dec 7, 2022

When in calls, the audio isn't redirected over bluetooth headsets/headphones. This happens probably because we check for the droid sink and if it exists the earpice, speak and wired headset is enforced. This stops callaudiod from looking through other sinks to find an available port.

https://github.com/droidian/callaudiod/blob/feature/bullseye/droid/src/cad-pulse.c#L131

g7 pushed a commit that referenced this issue Oct 14, 2023
When CallAudioOperation fails it invokes the set callback which usually
points to `complete_command_cb()` to return the result to DBus. However
cad_pulse_select_mode() invokes cad_pulse_mute_mic() without a callback
set hence we crash in the error path like:

 #1  0x0000aaaad7949aac in cad_pulse_mute_mic (mute=0, cad_op=0xaaab15802f40) at ../src/cad-pulse.c:1097
 #2  0x0000aaaad7949c5c in cad_pulse_select_mode (mode=CALL_AUDIO_MODE_DEFAULT, cad_op=0xaaab15809730) at ../src/cad-pulse.c:950
 #3  0x0000aaaad7947b3c in cad_manager_handle_select_mode (object=0xaaab157e98d0, invocation=0xffffa4009c40, mode=0) at ../src/cad-manager.c:90
 ...

Guard against that case. Do so in other call sites as well so
we don't hit the same problem should we invoke those functions
internally as well.

To reproduce run `callaudiocli -m 0` on a system that does't
detect a suitable card.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant