From 15507e2cad842cdbe8739ebbea67a7d5c32c2073 Mon Sep 17 00:00:00 2001
From: David Roberts <dave.roberts@elastic.co>
Date: Wed, 18 Oct 2023 09:34:54 +0100
Subject: [PATCH] [ML] Don't log errors for problems caused by shape of input
 data (#100996)

Logging errors in response to user input can cause enormous volumes
of output, which then obscures errors caused by bugs in the software.
---
 .../deployment/InferencePyTorchAction.java          | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/deployment/InferencePyTorchAction.java b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/deployment/InferencePyTorchAction.java
index 474933236d196..c91efb09d3cae 100644
--- a/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/deployment/InferencePyTorchAction.java
+++ b/x-pack/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/inference/deployment/InferencePyTorchAction.java
@@ -9,10 +9,12 @@
 
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
+import org.elasticsearch.ElasticsearchException;
 import org.elasticsearch.action.ActionListener;
 import org.elasticsearch.core.Nullable;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.inference.InferenceResults;
+import org.elasticsearch.rest.RestStatus;
 import org.elasticsearch.tasks.CancellableTask;
 import org.elasticsearch.tasks.TaskCancelledException;
 import org.elasticsearch.threadpool.ThreadPool;
@@ -109,6 +111,17 @@ protected void doRun() throws Exception {
         } catch (IOException e) {
             logger.error(() -> "[" + getDeploymentId() + "] error writing to inference process", e);
             onFailure(ExceptionsHelper.serverError("Error writing to inference process", e));
+        } catch (ElasticsearchException e) {
+            // Don't log problems related to the shape of the input as errors
+            if (e.status().getStatus() >= RestStatus.INTERNAL_SERVER_ERROR.getStatus()) {
+                logger.error(() -> "[" + getDeploymentId() + "] internal server error running inference", e);
+            } else {
+                logger.debug(() -> "[" + getDeploymentId() + "] error running inference due to input", e);
+            }
+            onFailure(e);
+        } catch (IllegalArgumentException e) {
+            logger.debug(() -> "[" + getDeploymentId() + "] illegal argument running inference", e);
+            onFailure(e);
         } catch (Exception e) {
             logger.error(() -> "[" + getDeploymentId() + "] error running inference", e);
             onFailure(e);