Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment bypass mechanism to use named variables #1482

Open
AlexSkrypnyk opened this issue Dec 18, 2024 · 0 comments
Open

Update deployment bypass mechanism to use named variables #1482

AlexSkrypnyk opened this issue Dec 18, 2024 · 0 comments

Comments

@AlexSkrypnyk
Copy link
Member

In deploy.sh:

# Allow skipping deployment by providing `$VORTEX_DEPLOY_SKIP_PR_<NUMBER>`
# variable with value set to "1", where `<NUMBER>` is a PR number name with
# spaces, hyphens and forward slashes replaced with underscores and then
# capitalised.
#

This requires modifying GHA config because it does not allow to pass all variables to the step (it requires to explicitly map vars to the environment variables).

This mechanism needs to be updated to use $VORTEX_DEPLOY_SKIP_PRS and $VORTEX_DEPLOY_SKIP_BRANCHES and use a comma-separated list within a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: BACKLOG
Development

No branches or pull requests

1 participant