Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for .env.local in docker-compose.yml is not yet provided by Lagoon #1286

Open
AlexSkrypnyk opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
State: Confirmed The issue was triaged and confirmed for development Type: Chore Issue is related to maintenance UPSTREAM Issue or pull request is related to an upstream project
Milestone

Comments

@AlexSkrypnyk
Copy link
Member

The PR #1196 added support for .emv.local in docker-compose.yml:

  env_file:
    - path: .env
      required: false
    - path: .env.local
      required: false

Deploying this to Lagoon failed the outdated validator:

##############################################
STEP Docker Compose Validation: Completed at 2024-04-25 06:50:46 (UTC) Duration 00:00:01 Elapsed 00:00:02
##############################################

##############################################
Warning!
There are issues with your docker compose file that lagoon uses that should be fixed.
You can run docker compose config locally to check that your docker-compose file is valid.
##############################################

2 error(s) decoding: * 'env_file[0]' expected type 'string', got unconvertible type 'map[string]interface {}', value: 'map[path:.env required:false]' * 'env_file[1]' expected type 'string', got unconvertible type 'map[string]interface {}', value: 'map[path:.env.local required:false]'

##############################################

There is an open issue in Lagoon uselagoon/build-deploy-tool#252 and a PR https://github.com/uselagoon/build-deploy-tool/pull/304/files

The change done in #1196 in the Scaffold needs to be reverted until this new format is supported.

@github-project-automation github-project-automation bot moved this to BACKLOG in Vortex Apr 25, 2024
@AlexSkrypnyk AlexSkrypnyk self-assigned this Apr 25, 2024
@AlexSkrypnyk AlexSkrypnyk added the UPSTREAM Issue or pull request is related to an upstream project label Apr 25, 2024
@AlexSkrypnyk AlexSkrypnyk added Type: Chore Issue is related to maintenance State: Confirmed The issue was triaged and confirmed for development labels Apr 25, 2024
@AlexSkrypnyk AlexSkrypnyk added this to the 2.1 milestone Apr 29, 2024
@AlexSkrypnyk AlexSkrypnyk modified the milestones: 24.12.0, 25.1.0 Sep 2, 2024
@AlexSkrypnyk AlexSkrypnyk modified the milestones: 25.1.0, 25.2.0 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Confirmed The issue was triaged and confirmed for development Type: Chore Issue is related to maintenance UPSTREAM Issue or pull request is related to an upstream project
Projects
Status: BACKLOG
Development

No branches or pull requests

1 participant