pkg: danctnix: osk-sdl: upgrade to 0.67 #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShapeShifter499
changed the title
|
Please squash all the commits and provide details about the modification you made in commit message. |
ShapeShifter499
force-pushed
the
master
branch
3 times, most recently
from
7482671 to
fdeccb5
Compare
|
How does this look? |
ShapeShifter499
force-pushed
the
master
branch
2 times, most recently
from
bb4398b to
f89306e
Compare
|
made a couple of minor edits, should be good now |
|
Can you switch the package to VCS and put the commit in a variable? Such example is here and VCS package guidelines. Other than that, LGTM. |
ShapeShifter499
force-pushed
the
master
branch
from
f89306e to
de08042
Compare
|
There, made the update EDIT: hang on |
ShapeShifter499
force-pushed
the
master
branch
2 times, most recently
from
3637080 to
dac7e23
Compare
|
Okay now it should be good, forgot that I had to also update where it would 'cd' into for the source |
ShapeShifter499
force-pushed
the
master
branch
from
dac7e23 to
d0dfb44
Compare
|
Since this is a package pulled from git, please use pkgver function. See VCS package guidelines |
|
Okay well should I tie this package to the latest source like how a "-git" package works on the AUR or just keep the commit tag but include the git tag as the pkgver? |
*Remove unneeded quiet line. It doesn't do anything in our hook *Ensure IFS is reset. Not resetting IFS may conflict with other hooks and kernel command line variables *Change PKGBUILD to build 0.67
ShapeShifter499
force-pushed
the
master
branch
from
d0dfb44 to
754832b
Compare
|
Like this? |
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.