Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: rewrite build.sh without guzuta #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArenM
Copy link
Contributor

@ArenM ArenM commented Jan 8, 2022

WARNING: this is incompatible with guzuta, it may overwrite database files generated by guzuta, do not attempt to use this with repositories managed by guzuta. Hopefully this will be addressed by a future version of the script.

This has the benefit of also being able to use makearmpkg from the armutils-git package to crossbuild packages from an x86 machine.

WARNING: this is incompatible with guzuta, it may overwrite database
files generated by guzuta, do not attempt to use this with repositories
managed by guzuta. Hopefully this will be addressed by a future version
of the script.

This has the benefit of also being able to use makearmpkg from the
armutils-git package to crossbuild packages from an x86 machine.

# TODO: detect corssbuild for arm
if [ "$PKG_ARCH" = "aarch64" ]; then
MAEKCHROOTPKG=${MAEKCHROOTPKG:-makearmpkg}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%s/MAEKCHROOTPKG/MAKECHROOTPKG/g

}

add_all_pkgs() {
repo-add "$REPO_DB" "$PKG_REPO_DIR"/*.pkg.tar.*
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It would be nice with support for signing (-s).
  • Rather than fully nuking the db each time, an option would be to do repo-add -R

done


#
# Interenal variables
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Interenal variables
# Internal variables

# Move built files, and update database
for package in "$PKGDEST"/*; do
cp "$package" "$PKG_REPO_DIR"
repo-add "$REPO_DB" "$PKG_REPO_DIR/$(basename "$package")"
Copy link

@3nprob 3nprob Feb 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo-add "$REPO_DB" "$PKG_REPO_DIR/$(basename "$package")"
gpg --detach-sign --batch --no "$PKG_REPO_DIR/$(basename "$package")"
repo-add -v -s -R "$REPO_DB" "$PKG_REPO_DIR/$(basename "$package")"

@3nprob
Copy link

3nprob commented Feb 22, 2022

FYI if you are not aware, a slower but more precise option to get output files for a PKGBUILD:

pushd $PKG_REPO_DIR && makepkg --packagelist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants