Increase margin around cursor outline item

Because it causes artifacting in software renderer mode with the canvas rotated without this.
drawpile · Aug 25, 2024 · 5647a4c · 5647a4c
1 parent 31e5010
commit 5647a4c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -11,6 +11,7 @@ Unreleased Version 2.2.2-pre
  * Fix: Scale outer color wheel ring with the size of the widget. Thanks MorrowShore for reporting.
  * Feature: Preview selected color on the color wheel. Can be toggled in the dock's menu. Thanks MorrowShore for suggesting.
  * Fix: Allow pressing the numpad enter key to apply an action and Ctrl+Equal in addition to Ctrl+Plus to zoom in. Thanks MachKerman and Sinamer for reporting.
+ * Fix: Prevent artifacts around brush cursor when the canvas is rotated in software renderer mode. Thanks Sinamer for reporting.
 
 2024-08-09 Version 2.2.2-beta.3
  * Fix: Use more accurate timers for performance profiles if the platform supports it.

diff --git a/src/desktop/scene/outlineitem.cpp b/src/desktop/scene/outlineitem.cpp
@@ -92,10 +92,11 @@ void OutlineItem::updateVisibility()
 	bool visible = m_actuallyVisible;
 #endif
 	setVisible(visible);
-	QRectF outerBounds = visible ? m_bounds.marginsAdded(QMarginsF(
-									   m_outlineWidth, m_outlineWidth,
-									   m_outlineWidth, m_outlineWidth))
-								 : QRectF();
+	QRectF outerBounds;
+	if(visible) {
+		qreal m = m_outlineWidth + 1.0;
+		outerBounds = m_bounds.marginsAdded(QMarginsF(m, m, m, m));
+	}
 	if(outerBounds != m_outerBounds) {
 		refreshGeometry();
 		m_outerBounds = outerBounds;