From 232de1bf6fe1ae97cc5ef996023033fc3db2fd6c Mon Sep 17 00:00:00 2001 From: Kyle Johnson Date: Thu, 5 Aug 2021 14:47:35 -0400 Subject: [PATCH] aws - security-group - references ingress/egress rules bug fix (#6838) --- c7n/resources/vpc.py | 2 +- tests/test_vpc.py | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/c7n/resources/vpc.py b/c7n/resources/vpc.py index 7d55a4f6fb1..1a4a38d54ed 100644 --- a/c7n/resources/vpc.py +++ b/c7n/resources/vpc.py @@ -1211,7 +1211,7 @@ def process_sg_references(self, perm, owner_id): if not sg_perm: return False - sg_group_ids = [p['GroupId'] for p in sg_perm if p['UserId'] == owner_id] + sg_group_ids = [p['GroupId'] for p in sg_perm if p.get('UserId', '') == owner_id] sg_resources = self.manager.get_resources(sg_group_ids) vf = ValueFilter(sg_refs, self.manager) vf.annotate = False diff --git a/tests/test_vpc.py b/tests/test_vpc.py index 0572c3caef3..03ba7785079 100644 --- a/tests/test_vpc.py +++ b/tests/test_vpc.py @@ -2196,7 +2196,6 @@ def test_security_group_reference_ingress_filter(self): session_factory=factory, ) resources = p.run() - self.assertEqual(len(resources), 1) def test_security_group_reference_egress_filter(self): @@ -2219,7 +2218,6 @@ def test_security_group_reference_egress_filter(self): session_factory=factory, ) resources = p.run() - self.assertEqual(len(resources), 1) def test_egress_ipv6(self):