From bc03ab1f2045de5dfa8f7a800871cee7556d2d8a Mon Sep 17 00:00:00 2001 From: vincent-gao Date: Tue, 29 Oct 2024 09:11:37 +1100 Subject: [PATCH 1/2] [SD-115] conflicting valid in textarea and textfield (#529) --- modules/tide_webform/tide_webform.module | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/tide_webform/tide_webform.module b/modules/tide_webform/tide_webform.module index 4755aedc1..976647998 100644 --- a/modules/tide_webform/tide_webform.module +++ b/modules/tide_webform/tide_webform.module @@ -43,7 +43,7 @@ function tide_webform_form_alter(&$form, FormStateInterface $form_state, $form_i if ($form_id == 'webform_ui_element_form') { $form['#after_build'][] = 'tide_webform_webform_ui_element_form_after_build'; $form['#attached']['library'][] = 'tide_webform/webform'; - if (isset($form['properties']['form']['length_container']['maxlength']) && array_key_exists('#default_value', $form['properties']['form']['length_container']['maxlength'])) { + if (isset($form['properties']['form']['length_container']['maxlength']) && array_key_exists('#default_value', $form['properties']['form']['length_container']['maxlength']) && $form['properties']['type']['#value'] === 'textfield') { $default_value = NestedArray::getValue($form, [ 'properties', From db3d191f109755a01f8cf61539eb9711468368a6 Mon Sep 17 00:00:00 2001 From: Yeni Atencio <47239456+yeniatencio@users.noreply.github.com> Date: Tue, 29 Oct 2024 09:41:18 +1100 Subject: [PATCH 2/2] reorder parameters (#531) * Made the time required as it is marked as deprecated for Drupal 10.3. --------- Co-authored-by: Md Nadim Hossain --- modules/tide_site/src/AliasManager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/tide_site/src/AliasManager.php b/modules/tide_site/src/AliasManager.php index b11506c88..7bd15d762 100644 --- a/modules/tide_site/src/AliasManager.php +++ b/modules/tide_site/src/AliasManager.php @@ -26,7 +26,7 @@ class AliasManager extends CoreAliasManager { /** * {@inheritdoc} */ - public function __construct(AliasRepositoryInterface $repository, AliasWhitelistInterface $whitelist, LanguageManagerInterface $language_manager, CacheBackendInterface $cache, protected ?TimeInterface $time = NULL, AliasStorageHelper $alias_helper) { + public function __construct(AliasRepositoryInterface $repository, AliasWhitelistInterface $whitelist, LanguageManagerInterface $language_manager, CacheBackendInterface $cache, protected ?TimeInterface $time, AliasStorageHelper $alias_helper) { parent::__construct($repository, $whitelist, $language_manager, $cache, $time); $this->aliasHelper = $alias_helper; }