Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Typo in the Paper #1

Open
XuRunhui opened this issue Sep 9, 2024 · 1 comment
Open

Potential Typo in the Paper #1

XuRunhui opened this issue Sep 9, 2024 · 1 comment

Comments

@XuRunhui
Copy link

XuRunhui commented Sep 9, 2024

image

I wonder whether this is a typo in your formula or I have wrongly understood you idea.

@dpaleka
Copy link
Owner

dpaleka commented Sep 9, 2024

The equation in the paper is wrong, thanks! But the fix is a bit different.
We add B to both tokens i and R:

The final equation is y_R^B - y_i^B = z_R - z_i. We will update this in the next version.
The following sentence in the paper might make it clearer:

Since we can observe 5 logprobs, we can compare the reference token R to four tokens per query, by adding a large bias that pushes all four tokens into the top 5 (along with the reference token).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants