Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few suggestions #29

Open
singhsays opened this issue Jan 6, 2016 · 0 comments
Open

A few suggestions #29

singhsays opened this issue Jan 6, 2016 · 0 comments

Comments

@singhsays
Copy link

Hey Doug,

Recently came across sleepy, great work on the micro framework!

A few minor suggestions.

  • Instead of embedding the *NotSupported types, why not just define the default implementation of methods directly on resource e.g http://play.golang.org/p/gXF2iFohYz
  • instead of binding to a port, maybe optionally add a method to accept a ServeMux or mux subrouter and bind routes to it. That way, sleepy can be used for a subset of all routes in an app and others non REST endpoints can be bound to the main router, leaving the flexibility of starting and running the server outside sleepy.

Happy to send a PR if you see any value in these suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant