Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: uncatch Error in src/app/admin/states/users/users.coffee #641

Open
lst97 opened this issue Dec 8, 2022 · 1 comment
Open

BUG: uncatch Error in src/app/admin/states/users/users.coffee #641

lst97 opened this issue Dec 8, 2022 · 1 comment

Comments

@lst97
Copy link
Contributor

lst97 commented Dec 8, 2022

Problem happened in 7.0-dev

line 35:

if response.error.error?
    return alertService.add("danger", "Error: " + response.error.error, 6000)

potential fix, but should fix that in the API response instead.

if response?
    return alertService.add("danger", "Error: " + response, 6000)

response expect an object but string are are used.

uncatch_error

After the fix:
Screenshot 2022-12-08 at 3 23 50 pm
@lst97
Copy link
Contributor Author

lst97 commented Dec 8, 2022

Pull Request: #642

@lst97 lst97 changed the title Uncatch Error in src/app/admin/states/users/users.coffee BUG: uncatch Error in src/app/admin/states/users/users.coffee Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lst97