Call Correct HtmlHelp Overload #12511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyKuhne
approved these changes
Nov 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12511 +/- ##
===================================================
- Coverage 75.74927% 75.73892% -0.01036%
===================================================
Files 3156 3157 +1
Lines 636084 636097 +13
Branches 47001 47002 +1
===================================================
- Hits 481829 481773 -56
- Misses 150787 150861 +74
+ Partials 3468 3463 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/winforms/actions/runs/11941857110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12505
In .NET 8 when calling
Help.ShowHelpwith a .chm file and an integer ID for the Topic ID, we would call HtmlHelp overload with cast toIntPtr, taking the integer ID as is. In .NET 9 after updating to use cswin32, we updated to call the wrong overload where instead of taking the integer ID as is, we would take its address, causing the help page to fail to show because topic ID doesn't exist. Tested changes manually to confirm fix. There is not a good way to unit test this it seems asHelp.ShowHelpreturns void.Microsoft Reviewers: Open in CodeFlow