Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common code to assemblies #12506

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

JeremyKuhne
Copy link
Member

@JeremyKuhne JeremyKuhne commented Nov 18, 2024

Most of what was in the Common folder was only used in one place or could live in a shared assembly. Moved what I easily could.

Microsoft Reviewers: Open in CodeFlow

Most of what was in the Common folder was only used in one place or could live in a shared assembly. Moved what I easily could.
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.74723%. Comparing base (f0e509c) to head (3644d14).
Report is 5 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #12506         +/-   ##
===================================================
+ Coverage   75.69129%   75.74723%   +0.05594%     
===================================================
  Files           3151        3156          +5     
  Lines         635805      636084        +279     
  Branches       46978       47001         +23     
===================================================
+ Hits          481249      481816        +567     
+ Misses        151124      150808        -316     
- Partials        3432        3460         +28     
Flag Coverage Δ
Debug 75.74723% <100.00000%> (+0.05594%) ⬆️
integration 18.20021% <100.00000%> (+0.01976%) ⬆️
production 49.32190% <100.00000%> (+0.10251%) ⬆️
test 97.04658% <ø> (+0.00149%) ⬆️
unit 46.49502% <0.00000%> (+0.23706%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@JeremyKuhne JeremyKuhne enabled auto-merge (squash) November 19, 2024 00:08
@JeremyKuhne JeremyKuhne merged commit 7896a6e into dotnet:main Nov 19, 2024
8 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0 Preview1 milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants