Fixed the issue where edit textBox loses focus when using up/down to switch property values ​​on edit textBox

[LeafShi1]

Fixes #12440

Proposed changes

• When setting a property with the [RefreshProperties(RefreshProperties.All)] attribute, suppress recalculation and reset constants for the entire property page

Customer Impact

• The rectangle in the edit text box always stays in the edit textbox when changing the property value using the up/down buttons

Regression?

• No

Risk

• Mininal

Screenshots

Before

The rectangle always back to focus on entire row after using the up/down changed the property values directly in the edit textbox

After

The rectangle in the edit text box always stays in the edit textbox when changing the property value using the up/down buttons

Test methodology

• Manually

Test environment(s)

• .net 10.0.0-alpha.1.24554.9

Microsoft Reviewers: Open in CodeFlow

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.73581%. Comparing base (65f897b) to head (7b9e0f2).
Report is 47 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #12431         +/-   ##
===================================================
+ Coverage   75.65407%   75.73581%   +0.08173%     
===================================================
  Files           3150        3153          +3     
  Lines         635831      635797         -34     
  Branches       47020       46973         -47     
===================================================
+ Hits          481032      481526        +494     
+ Misses        151352      150839        -513     
+ Partials        3447        3432         -15     

Flag	Coverage Δ
Debug	75.73581% <0.00000%> (+0.08173%)	⬆️
integration	18.27145% <0.00000%> (+0.02238%)	⬆️
production	49.31168% <0.00000%> (+0.11336%)	⬆️
test	97.05103% <ø> (+0.02079%)	⬆️
unit	46.28890% <0.00000%> (+0.13293%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[LeafShi1]

The private dlls have been tested, no regression issue was found.

[Tanya-Solyanik]

@LeafShi1 - please fix a link to the issue, right now it points to another PR

Actually, this is a non-regression problem found when testing PR #12356. No issue was filed before.
I created an issue for it and the issue link has been updated.

[Tanya-Solyanik]

COuld you please help me understand this fix? I would expect that in this scenario OwnerGrid.HavePropertyEntriesChanged is true.

[LeafShi1]

When setting a property, the SetPropertyValue method is called. In this method, the Refresh method is called to refresh the property list based on the Attribute of the property.

But in fact, when setting the AutoSize property, the number and structure of properties in the property list will not change. We only need to refresh the linked property values, so there is no need to recreate the property list.

[LeafShi1]

When we switch the value of the edit text by pressing the up and down keys, the SelectAll event will be called, and this event will eventually enter the SelectInternal method. The AI ​​notification is sent from the SelectInternal method here, but the notification sent here is UIA_Text_TextSelectionChangedEventId. If we add notification UIA_AutomationFocusChangedEventId to it, this problem also can be resolved.

[Tanya-Solyanik]

But in fact, when setting the AutoSize property, the number and structure of properties in the property list will not change. We only need to refresh the linked property values, so there is no need to recreate the property list.

Please verify this with a Label control and Multiline property ( if still applicable to the new approach)

[Tanya-Solyanik]

Please test with NVDA and JAWS.

[LeafShi1]

Tested with NVDA and JAWS, same results for both tools
And using the changes from commit1 and commit 2, same results too.

[ricardobossan]

Tested the changes and the TextBox does not lose focus when you press up/down.

Changes LGTM.

[Olina-Zhang]

Tested this PR change with several regression issues found. Need to investigate.

[LeafShi1]

@Tanya-Solyanik The second commit caused 3 unstabled regression issues, RaiseAutomationEvent(UIA_EVENT_ID.UIA_AutomationFocusChangedEventId) does not stably focus the accessibility rectangle on the edit text box, so consider the solution When setting a property with the [RefreshProperties(RefreshProperties.All)] attribute, only the relevant property values ​​are refreshed instead of recalculating and refreshing the entire property list in commit1. And commit1 has been tested before, no regression issue.

[Tanya-Solyanik]

ok, let's remove the fullRefresh test.