Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aquire .NET runtime with invalid version does not prompt to configure manually #1924

Open
vsccarl opened this issue Aug 16, 2024 · 1 comment

Comments

@vsccarl
Copy link

vsccarl commented Aug 16, 2024

Describe the bug.

When running the Sample: Aquire .NET Runtime command and providing an invalid version. e.g. 'foo', there should be a prompt to enter the path for dotnet.exe.

Please attach log file(s) here if you have any.

The log file location should be copied to your clipboard if you came from VS Code.

Reproduction Steps

Run the 'Sample: Acquire .NET runtime' command. You should be asked to enter a Major.Minor version, please enter an invalid version (for example, 'foo').
You should see an error popup in the bottom right corner of VSCode, select the 'Configure manually'option as seen below.

image

You should be prompted to enter the path to dotnet.exe. You can enter the path to any dotnet.exe you have installed on your machine. If you have installed .NET with one of the default installers you can just press enter, as the dialog is prepopulated with the default install location.

Expected Behavior

You should see a popup saying 'Set .NET path to { the path you entered }. Please reload VSCode to apply settings.'
Close and reopen VSCode. Run the command again ('Sample: Acquire .NET runtime' with an invalid version). You should see the message 'Using configured .NET path: { the path you entered }' in the output.

Exceptions & Errors (if any)

No response

.NET Install Tool Version

2.1.2

Your operating system? Please provide more detail, such as the version and or distro above.

Windows

VS Code Version

1.92.2

@nagilson
Copy link
Member

Thank you for the report

This is happening because of some of the new early on version parsing logic. I believe. This is not getting to the code which adds the button... which frankly is OK for now.. but should fix it in the long term.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants