Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML Literal Hot Reload Issue #75231

Closed
CoolCoderSuper opened this issue Sep 25, 2024 · 5 comments · Fixed by #75301
Closed

XML Literal Hot Reload Issue #75231

CoolCoderSuper opened this issue Sep 25, 2024 · 5 comments · Fixed by #75301
Labels
Interactive-EnC untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@CoolCoderSuper
Copy link

Version Used: 17.12.0 Preview 2.0

Steps to Reproduce:

  1. Edit text content in XML literal element or attribute and no changes will be detected.

If you add or remove an element or attributes hot reload works as expected.

Expected Behavior:
Hot reload would procede as normal.
Actual Behavior:
No changes are detected.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 25, 2024
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@CoolCoderSuper
Copy link
Author

Did some more test and it looks like if you add an additional text node for example

<div>
cdscdsdcs
<br/>
</div>

to

<div>
cdscdsdcs
<br/>
hhhhhhhhhhhhhh
</div>

Hot reload will work.

If you change the type of the tag hot reload will fail.

It seems that changes to existing nodes fail but additions and removals are detected properly.

@CoolCoderSuper
Copy link
Author

I attempted to debug it my self but I could figure out how to debug the remote services.
Is there a guide for this?

@CoolCoderSuper
Copy link
Author

I'm assuming the issue would be in VisualBasicEditAndContinueAnalyzer.
If this is the case are most edit "automatically" dealt with in AbstractEditAndContinueAnalyzer?
I assume that XML literals have already been lowered to constructor calls at this point if not how or when does that happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interactive-EnC untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants