Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LSP] Do not recompute syntax diagnostics if syntax has not changed #75241

Open
dibarbet opened this issue Sep 25, 2024 · 0 comments
Open

[LSP] Do not recompute syntax diagnostics if syntax has not changed #75241

dibarbet opened this issue Sep 25, 2024 · 0 comments
Assignees
Labels
Area-Analyzers Area-IDE LSP issues related to the roslyn language server protocol implementation

Comments

@dibarbet
Copy link
Member

Currently we always use the project dependent checksum to determine if there are any changes that might impact diagnostics - https://github.com/dotnet/roslyn/blob/main/src/LanguageServer/Protocol/Handler/Diagnostics/AbstractPullDiagnosticHandler.cs#L165

The request from the client is that for syntax diagnostic sources, we use the document / syntax only checksum to determine if there have been changes. This avoids unnecessary recomputation of the syntax only diagnostics when there is a change in another file for example

@dibarbet dibarbet added the LSP issues related to the roslyn language server protocol implementation label Sep 25, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Analyzers untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 25, 2024
@dibarbet dibarbet self-assigned this Sep 25, 2024
@arunchndr arunchndr removed the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Analyzers Area-IDE LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Development

No branches or pull requests

2 participants