Move HybridWebView platform code to handlers (attempt 2) #24952
Merged
+379
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And run everything through the mappers. Fixes #24269
|
We moved agents from Ventura to sonoma so thats why android is delaying |
Eilon
force-pushed
the
eilon/hwv-platform-cleanup-2
branch
from
32f859e
to
6e4ab72
Compare
By changing `HybridJavaScriptInterface` to a class, the JCW now says:
@android.webkit.JavascriptInterface
public void sendMessage (java.lang.String p0)
PureWeen
approved these changes
Oct 1, 2024
|
/backport to release/9.0.1xx-rc2 |
|
Started backporting to release/9.0.1xx-rc2: https://github.com/dotnet/maui/actions/runs/11133061157 |
samhouts
added
the
fixed-in-net9.0-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And run everything through the mappers.
Fixes #24269
Some history:
JavascriptInterfaceattribute was missing from the Java code, causing the method to not be available to the Android WebView (which is a critical part of how HybridWebView works). So the attribute was manually added.