-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shadow consistency on Android and iOS #24415
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @albyrock87! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
albyrock87
force-pushed
the
mobile-shadow-consistency
branch
from
August 26, 2024 09:25
aea0080
to
9b1153b
Compare
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
samhouts
added
the
area-drawing
Shapes, Borders, Shadows, Graphics, BoxView, custom drawing
label
Aug 27, 2024
Just linking this one for linking things: #24561 |
mattleibow
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice!
samhouts
added
the
fixed-in-net8.0-nightly
This may be available in a nightly release!
label
Sep 5, 2024
samhouts
added
the
fixed-in-net9.0-nightly
This may be available in a nightly release!
label
Oct 1, 2024
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
This may be available in a nightly release!
fixed-in-net8.0-nightly
This may be available in a nightly release!
labels
Oct 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-drawing
Shapes, Borders, Shadows, Graphics, BoxView, custom drawing
community ✨
Community Contribution
fixed-in-9.0.0-rc.2.24503.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As shown in #24414 shadows are not rendered properly in Android and iOS.
This PR fixes it, making as much consistent as possible with Figma.
Android is still not perfect, but it is very close.
Issues Fixed
Fixes #24414
Relates to #8796