Fix "Grey" cannot be used to set Background property #24325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Colors has both, but not Brush. so we should fix this in one way or another for consistency |
StephaneDelcroix
requested changes
Aug 21, 2024
StephaneDelcroix
previously approved these changes
Aug 23, 2024
mattleibow
previously approved these changes
Aug 23, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@devanathan-vaithiyanathan just waiting on your CLA acceptance :) |
|
@dotnet-policy-service agree |
devanathan-vaithiyanathan
dismissed stale reviews from mattleibow and StephaneDelcroix
via
3a763a4
|
/azp run |
PureWeen
approved these changes
Aug 26, 2024
|
Azure Pipelines successfully started running 3 pipeline(s). |
auto-merge was automatically disabled
August 27, 2024 12:54
Head branch was pushed to by a user without write access
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Hi @PureWeen , |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
approved these changes
Aug 30, 2024
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
The issue occurred because .NET MAUI's Brush class does not support color names with the British spelling "Grey" (e.g., Grey, DimGrey, SlateGrey). Instead, it only recognizes the American spelling "Gray." This led to a XFC0040 Cannot convert value "Grey" to "Microsoft.Maui.Controls.Brush" error when trying to use these color names in XAML.
Description of Change
To resolve this issue, I added the missing colors using the "Grey" spelling (Grey, DimGrey, SlateGrey, DarkGrey, DarkSlateGrey, LightGrey, LightSlateGrey). This fix ensures that these colors are now recognized and can be used in XAML.
Note: There is a known Visual Studio bug where the XAML preview does not display these colors correctly, even after the fix.
Issues Fixed
Fixes #21325
Output
Before
After
