-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Prevent the tap that closes an open SwipeView from being propagated to children #24275
base: main
Are you sure you want to change the base?
Conversation
an open swipeview will close on tap, so intercept the touch if the swipeview is currently open
Hey there @sjordanGSS! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
A more verbose explanation of the issue and the fix is here: #23921 (comment), I can add this to the PR description if desired. |
Hey @sjordanGSS thanks for your very first contribution! Exciting! A couple of things:
We appreciate you looking into this <3 |
Quick update on this: I've renamed the PR as requested, hopefully it's is a little more useful now. I've been trying to write unit tests for the change but have been having trouble getting things to work: Visual Studio 17.11.1 crashes when I open any solution file, and VS Code fails to run the unit test app with an error that it can't find MainActivity. I'm working on this between other things at my day job and we've already fixed the issue on our side so I'm not able to dedicate a whole lot of time to working this out. |
I've pushed a commit with two unit tests which I'm not able to run locally (I got the projects to load in Visual Studio, but it throws the same exception as VS Code: |
@dotnet-policy-service agree company="Global Stock Systems Ltd" |
/rebase |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
set automationId properties on test view tests currently succeed if they are run independently
@jsuarezruiz Thanks for running the tests. I've gotten the working on my pc now and I can see there are some problems with the tests I've written for this PR. I've pushed some changes, but it's currently in the situation where one test will fail if it is run immediately after the other. I'm still getting used to this testing framework unfortunately. Is there a better way to check if a button has been clicked than to set the text, and then check it in the test case? Thanks! |
…, add two of them and point one test at each
I've fixed the tests by duplicating the controls for each test. Can they be rerun? |
Description of Change
An open
SwipeView
will close on tap, so a tap on an openSwipeView
should be intercepted before it can be handled by child views. Otherwise tapping to close an open swipeview will result inButton
s,TapGestureRecognisers
etc withinSwipeView.Content
being activated.Issues Fixed
Fixes #23921