-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net9.0] Fix API23 Core device tests #24128
Conversation
dac006f
to
92a6164
Compare
5e4e64b
to
e592b9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's 2 different issues going on with API 23 Core Device Tests
Issue 1
Headless vs Visual Runner
-
Headless: When the xharness tests are ran headless against API 23 they run to completion and don't crash.
-
VisualRunner: If you use the VisualRunner and click "Run all tests" it crashes with the libskia issue.
Issue 2
For some reason xharness is failing to install/launch/find instrumentation on CI for API 23 and our Core Device Tests. I've done a side by side with Core and other projects and I can't figure out what's different. We're currently running all our device tests in debug mode, so I tested running in release mode. If you run in release mode then the xharness tests install and run successfully. So, I for this PR I've modified the android device tests so they run as release. We can fix the other platforms later, but for now this gets us back to working on Android.
8956567
to
ce0aca7
Compare
/rebase |
35467d4
to
367d00f
Compare
/rebase |
367d00f
to
bcb1242
Compare
Description of Change
It looks like for some unknown reason XHarness is unable to find the Maui Instrumentation class on our Core.Devices.csproj. I worked with @jonathanpeppers on this for a little bit and we couldn't really figure out why. It looks like if we build the device tests using a release configuration vs debug then XHarness is able to find everything. We should be doing this anyway, so that's the fix I'm going for here
I've left our
Controls.DeviceTests
as debug for now because they are locking up/freezing for some unknown reason when running. [Testing] Fix Controls.Device Tests so they can run as release #24337I've disabled some
StreamImageSource
tests when compiled forRelease
because for some reason these are failing when in release mode. [Testing] StreamImageSource.GetDrawableAsync currently doesn't work when ran in release mode on Core.DeviceTests #24338