Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] Fix API23 Core device tests #24128

Merged
merged 5 commits into from
Aug 27, 2024
Merged

[net9.0] Fix API23 Core device tests #24128

merged 5 commits into from
Aug 27, 2024

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Aug 9, 2024

Description of Change

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's 2 different issues going on with API 23 Core Device Tests

Issue 1

Headless vs Visual Runner

  • Headless: When the xharness tests are ran headless against API 23 they run to completion and don't crash.

  • VisualRunner: If you use the VisualRunner and click "Run all tests" it crashes with the libskia issue.

Issue 2

For some reason xharness is failing to install/launch/find instrumentation on CI for API 23 and our Core Device Tests. I've done a side by side with Core and other projects and I can't figure out what's different. We're currently running all our device tests in debug mode, so I tested running in release mode. If you run in release mode then the xharness tests install and run successfully. So, I for this PR I've modified the android device tests so they run as release. We can fix the other platforms later, but for now this gets us back to working on Android.

@PureWeen PureWeen changed the title [net9.0] Fix API23 Control device tests [net9.0] Fix API23 Core device tests Aug 16, 2024
@PureWeen PureWeen marked this pull request as ready for review August 20, 2024 19:54
@PureWeen PureWeen requested a review from a team as a code owner August 20, 2024 19:54
@PureWeen
Copy link
Member

/rebase

@PureWeen
Copy link
Member

/rebase

@rmarinho rmarinho merged commit 8865245 into net9.0 Aug 27, 2024
121 checks passed
@rmarinho rmarinho deleted the tryfix-android23 branch August 27, 2024 14:29
@samhouts samhouts added the fixed-in-net9.0-nightly This may be available in a nightly release! label Aug 27, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-net9.0-nightly This may be available in a nightly release! testing-green-ci
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants