Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MenuFlyoutSeparator is not working on MacCatalyst #19870

Open
MSicc opened this issue Jan 12, 2024 · 5 comments
Open

MenuFlyoutSeparator is not working on MacCatalyst #19870

MSicc opened this issue Jan 12, 2024 · 5 comments
Labels
area-controls-menubar Desktop MenuBarItems platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK)
Milestone

Comments

@MSicc
Copy link

MSicc commented Jan 12, 2024

Description

MenuItemSeparator does not show on MacCatalyst apps. It generates an empty menu item.

image

Steps to Reproduce

  1. Create a new MAUI app
  2. Add a menubar with MenuFlyoutSeparator
  3. Run the application

Sample Menu code

    <Shell.MenuBarItems>
        <MenuBarItem Text="Application">
            <MenuFlyoutItem Text="About MenuHandlingPlayground" />
            <MenuFlyoutSeparator IsEnabled="False" />
            <MenuFlyoutItem Text="Settings">
                <MenuFlyoutItem.KeyboardAccelerators>
                    <KeyboardAccelerator Key="," Modifiers="Cmd" />
                </MenuFlyoutItem.KeyboardAccelerators>
            </MenuFlyoutItem>
        </MenuBarItem>
        <MenuBarItem Text="File">
            <MenuFlyoutItem Text="Open file">
                <MenuFlyoutItem.KeyboardAccelerators>
                    <KeyboardAccelerator Key="O" Modifiers="Cmd" />
                </MenuFlyoutItem.KeyboardAccelerators>
            </MenuFlyoutItem>
           <MenuFlyoutSeparator />
            <MenuFlyoutItem Text="Close file">
                <MenuFlyoutItem.KeyboardAccelerators>
                    <KeyboardAccelerator Key="C" Modifiers="Alt,Cmd" />
                </MenuFlyoutItem.KeyboardAccelerators>
            </MenuFlyoutItem>
        </MenuBarItem>
    </Shell.MenuBarItems>

Link to public reproduction project repository

No response

Version with bug

8.0.3

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

macOS, I was not able test on other platforms

Affected platform versions

14.2.1

Did you find any workaround?

nope

Relevant log output

-
@MSicc MSicc added the t/bug Something isn't working label Jan 12, 2024
@jsuarezruiz jsuarezruiz added platform/macOS 🍏 macOS / Mac Catalyst area-controls-menubar Desktop MenuBarItems labels Jan 15, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jan 15, 2024
@ghost
Copy link

ghost commented Jan 15, 2024

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

@jsuarezruiz
Copy link
Contributor

<MenuFlyoutSeparator IsEnabled="False" />

Could you try not using the IsEnabled property?

@MSicc
Copy link
Author

MSicc commented Jan 16, 2024

<MenuFlyoutSeparator IsEnabled="False" />

Could you try not using the IsEnabled property?

That does not change anything. It generates the same empty item.

@samhouts samhouts added the legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) label Jan 31, 2024
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Feb 20, 2024
@XamlTest
Copy link

Verified this on 8.0.6. Repro on MacCatalyst, not repro on Windows 11 with below Project:
MenuHandingPlayground.zip

@Eilon Eilon added t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK) and removed legacy-area-desktop Windows / WinUI / Project Reunion & Mac Catalyst / macOS specifics (Menus & other Controls)) labels May 10, 2024
@samhouts samhouts removed s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 3, 2024
@samhouts samhouts added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 10, 2024
@markatosi
Copy link

I would like to mention that the Separator does display correctly if it's used in a SubItemMenu context in Maccatalyst

<MenuFlyoutSubItem Text="New" Clicked="MenuItem_Clicked">
                <MenuFlyoutItem Text="Blue"
                                Clicked="MenuItem_Clicked"
                                CommandParameter="LightBlue" />
                <MenuFlyoutItem Text="Coral"
                                Clicked="MenuItem_Clicked"
                                CommandParameter="LightCoral" />
                <MenuFlyoutSeparator></MenuFlyoutSeparator>	<= Worked Here!
                <MenuFlyoutItem Text="Cyan"
                                Clicked="MenuItem_Clicked"
                                CommandParameter="LightCyan" />
            </MenuFlyoutSubItem>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-menubar Desktop MenuBarItems platform/macOS 🍏 macOS / Mac Catalyst s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working t/desktop The issue relates to desktop scenarios (MacOS/MacCatalyst/Windows/WinUI/WinAppSDK)
Projects
None yet
Development

No branches or pull requests

6 participants