Add dedicated error message for dynamics

dotnet · Aug 10, 2023 · 3080efd · 3080efd
1 parent 78ba1a6
commit 3080efd
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/...tics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs b/...tics.Monitoring.HostingStartup/ParameterCapturing/FunctionProbes/FunctionProbesManager.cs
@@ -203,7 +203,7 @@ public async Task StartCapturingAsync(IList<MethodInfo> methods, CancellationTok
                     ulong functionId = method.GetFunctionId();
                     if (functionId == 0)
                     {
-                        throw new NotSupportedException(method.Name);
+                        throw new InvalidOperationException(string.Format(CultureInfo.InvariantCulture, ParameterCapturingStrings.ErrorMessage_FunctionDoesNotHaveIdFormatString, method.Name));
                     }
 
                     uint[] methodBoxingTokens = BoxingTokens.GetBoxingTokens(method);

diff --git a/...oft.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingService.cs b/...oft.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingService.cs
@@ -96,7 +96,7 @@ public void FailedToCapture(Guid requestId, ParameterCapturingEvents.CapturingFa
         public void ProbeFault(Guid requestId, InstrumentedMethod faultingMethod)
         {
             // TODO: Report back this fault on ParameterCapturingEventSource. 
-            _logger?.LogInformation(ParameterCapturingStrings.StoppingParameterCapturingDueToProbeFault, faultingMethod.MethodWithParametersTemplateString);
+            _logger?.LogWarning(ParameterCapturingStrings.StoppingParameterCapturingDueToProbeFault, faultingMethod.MethodWithParametersTemplateString);
 
             try
             {

diff --git a/...ostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingStrings.Designer.cs b/...ostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingStrings.Designer.cs
diff --git a/...t.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingStrings.resx b/...t.Diagnostics.Monitoring.HostingStartup/ParameterCapturing/ParameterCapturingStrings.resx
@@ -117,6 +117,9 @@
   <resheader name="writer">
     <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
+  <data name="ErrorMessage_FunctionDoesNotHaveIdFormatString" xml:space="preserve">
+    <value>Method '{0}' is unsupported, it does not have a FunctionID.</value>
+  </data>
   <data name="ErrorMessage_ProbeStateMismatchFormatString" xml:space="preserve">
     <value>Mismatch probe state. Expected '{0}', was '{1}'.</value>
   </data>
@@ -142,7 +145,7 @@
     <value>Stopped parameter capturing.</value>
   </data>
   <data name="StoppingParameterCapturingDueToProbeFault" xml:space="preserve">
-    <value>Parameter capturing encountered an internal exception when processing '{method}', stopping.</value>
+    <value>Parameter capturing encountered an internal error when processing '{method}', stopping.</value>
   </data>
   <data name="ThisParameterName" xml:space="preserve">
     <value>this</value>