Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic kernel execise - feedback #70

Open
LittleLittleCloud opened this issue Jun 24, 2024 · 3 comments
Open

semantic kernel execise - feedback #70

LittleLittleCloud opened this issue Jun 24, 2024 · 3 comments

Comments

@LittleLittleCloud
Copy link
Contributor

Sample 1

Spell error in initilization
image

Sample 2

  • spell error: compilation -> completion
    image

  • spell error: whilw -> while
    image

  • resonse -> response
    image

Sample 3

  • The LLM invokes the funciton call before I even start asking my age when I use gpt-3.5-turbo
    image

Sample 4

  • initizing -> initializing and kerenel -> kernel
    image

Sample 5

  • Directoty -> Directory
    image

  • Whitespace missing and --prerelease tag is missing
    image

  • The highlighted using statement has already been added in previous steps
    image

  • Need to disable SKEXP warning between step 4 and 5
    image

Sample 6

  • Maksure -> make sure
    image

  • missing suppress skexp warning in source
    image

  • missing Kernel after Semantic
    image

Sample 7

  • The Complete sample project section is still for Sample 6
    image

  • Sevice -> Service
    image

  • kerel -> kernel
    image

  • Miss semi-colomn at the end of code snippet
    image

  • Not clear on how to invoke web api from console. Do we miss the setup for openapi page?
    image

@zewditu
Copy link
Contributor

zewditu commented Jun 24, 2024

image

Sample 4 does not have "using Microsoft.SemanticKernel.Connectors.OpenAI"
these are using statements in sample 4

using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.SemanticKernel;
using Microsoft.SemanticKernel.ChatCompletion;

@zewditu
Copy link
Contributor

zewditu commented Jun 24, 2024

For this I do not think you are not on latest
image

@zewditu
Copy link
Contributor

zewditu commented Jun 25, 2024

The LLM invokes the funciton call before I even start asking my age when I use gpt-3.5-turbo
image

This is OpenAI model specific thing, if we add a persona like
chatHistory.AddSystemMessage("Respond only to requested information. If the user says hi just respond greeting do not tell extra information"); It responds only greeting unless otherwise we ask age, but the main goal of this sample is to match Stephen's video not beyond that. Hence, I will update the prompt to the same prompt pattern of Stephen My name is Alice. How old am I? https://youtu.be/jrNfKeGSuCg?t=553

Naïve guess: the reason it responds age when name is provided because its calling behavior is set to AutoInvokeKernelFunctions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants