Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Report errors when build fails #73

Closed
dotherightthing opened this issue Apr 17, 2018 · 3 comments
Closed

Report errors when build fails #73

dotherightthing opened this issue Apr 17, 2018 · 3 comments
Assignees
@dotherightthing
Labels
enhancement

Comments

@dotherightthing
Copy link
Owner

dotherightthing commented Apr 17, 2018 •
edited
Loading

e.g. https://github.com/dotherightthing/wpdtrt-contentsections
@dotherightthing dotherightthing self-assigned this Apr 17, 2018
@dotherightthing
Copy link
Owner Author

Some Googling of this suggests that any error should stop a CI build

@dotherightthing
Copy link
Owner Author

dotherightthing commented Oct 6, 2019 •
edited
Loading

This affects Cypress too. The issue is that there is no feedback as to why the build failed.

Suggest the following:

@dotherightthing dotherightthing changed the title Allow build to continue if unit tests fail? Report errors when build fails Oct 6, 2019
@dotherightthing dotherightthing pinned this issue Oct 6, 2019
@dotherightthing dotherightthing mentioned this issue Oct 6, 2019
Closed
dotherightthing added a commit to dotherightthing/wpdtrt-gallery that referenced this issue Oct 6, 2019
@dotherightthing
Suppress failing test (see #67 and dotherightthing/wpdtrt-plugin-boil…
c7c4def 
…erplate#73)
dotherightthing added a commit to dotherightthing/wpdtrt-gallery that referenced this issue Oct 6, 2019
@dotherightthing
Merge branch 'development'
470c1ef 
* development: (75 commits)
  Housekeeping
  Remove incomplete implementation of cy.waitForResources
  Update notes for next release
  Suppress failing test (see #67 and dotherightthing/wpdtrt-plugin-boilerplate#73)
  Update wpdtrt-plugin-boilerplate, from 1.6.11 to 1.6.12
  Remove duplicate entry from Cypress config file
  Don't commit Cypress screenshots and videos
  Add Cypress projectId to identify run recordings
  Update wpdtrt-plugin-boilerplate, from 1.6.10 to 1.6.11
  Add fallback array if no options sent to output template
  Update wpdtrt-plugin-boilerplate, from 1.6.9 to 1.6.10
  Remove redundant attribute
  Only update the viewer if a different thumbnail was selected
  End to End tests - gallery thumbs - default vs initial state
  Update wpdtrt-plugin-boilerplate, from 1.6.8 to 1.6.9
  End to End tests - gallery thumbs, replace data-viewing with aria-expanded
  Run Cypress tests in CI
  End to End tests - gallery thumbs
  End to end tests, hide items accessibly, remove redundant attributes
  Clean up tenonAnalyzeHtml output
  ...
@dotherightthing
Copy link
Owner Author

exec runs in a child_process, which limits the feedback that we can get from it in the parent Node.js process.

Changed to execa and implemented a try .. catch to ensure that error messages are caught and exposed in Travis's build log:

Screen Shot 2019-10-11 at 2 35 38 PM

@dotherightthing dotherightthing mentioned this issue Oct 11, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dotherightthing dotherightthing

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dotherightthing