Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Push Publishing dependency failure when try to send a second level of related content #31036

Open
freddyDOTCMS opened this issue Jan 2, 2025 · 3 comments · Fixed by #31054

Comments

@freddyDOTCMS
Copy link
Contributor

freddyDOTCMS commented Jan 2, 2025

Parent Issue

#29031

Problem Statement

When you have a second level of related content then is it not send by PP even when you select the "Everything and Dependencies" Filter

Steps to Reproduce

  • Create a Content Type called Type3 with just a Text field called title
  • Create a Content Type called Type2 with a couple of field: Text one called title, and a ONE_TO_ONE relationship called rel pointing to Type3.
  • Create a Content Type called Type1 with a couple of field: Text one called title, and a ONE_TO_ONE relationship called rel pointing to Type2.
  • Crate Type3 Contentlet and set 'A' as its title.
  • Crate Type2 Contentlet and set 'B' as its title and related it with 'A'.
  • Crate Type1 Contentlet and set 'C' as its title and related it with 'B'.
  • Create a new PP environment and end point pointing to demo.dotcms.com
  • Send 'C' to demo

You are going to see that demo receive C and B but not A

Acceptance Criteria

Must sent the second level related content
We ultimately decided to send all related content, regardless of its level.

We are not getting any Out of Memory issue because when we have circular references each asset is processed only once. I’ve also added an integration test to cover this scenario, so that is why I did not include any depth config property.

dotCMS Version

latest in main

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@freddyDOTCMS
Copy link
Contributor Author

freddyDOTCMS commented Jan 3, 2025

We ultimately decided to send all related content, regardless of its level.

We are not getting any Out of Memory issue because when we have circular references each asset is processed only once. I’ve also added an integration test to cover this scenario, so that is why I did not include any depth config property.

Copy link

github-actions bot commented Jan 3, 2025

@freddyDOTCMS freddyDOTCMS moved this from In Progress to In Review in dotCMS - Product Planning Jan 3, 2025
@freddyDOTCMS freddyDOTCMS moved this from In Review to Internal QA in dotCMS - Product Planning Jan 6, 2025
@jcastro-dotcms jcastro-dotcms self-assigned this Jan 8, 2025
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED ✅

  • Docker image: trunk_1956937

When you push publish the last child in a chain of related content using the Everything and Dependencies filter, we're now pushing such a child along with all of its parent contents, whether it's 2 or more parents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants