Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UVE: Show "Create New Language Version" Dialog Before Updating Query Params #30772

Closed
rjvelazco opened this issue Nov 26, 2024 · 3 comments · Fixed by #30849
Closed

UVE: Show "Create New Language Version" Dialog Before Updating Query Params #30772

rjvelazco opened this issue Nov 26, 2024 · 3 comments · Fixed by #30849

Comments

@rjvelazco
Copy link
Contributor

rjvelazco commented Nov 26, 2024

Parent Issue

N/A

Task

Show the "Create New Language Version" dialog when the user clicks on a language where the page does not exist. This will allow us to show the dialog before updating the query parameters, as we do right now, and avoid triggering an unnecessary request if the user chooses not to create the new language version.

Video

issue-1.mov

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  • Detect when the user clicks on a language where the page does not exist.
  • Show the "Create New Language Version" dialog before updating the query parameters.
  • Ensure that the dialog allows the user to confirm or cancel the creation of the new language version.
  • If the user confirms, proceed with updating the query parameters.
  • If the user cancels, do not update the query parameters and avoid triggering the unnecessary request.
  • Verify that the application functions correctly after the changes.
  • Ensure that all unit tests pass successfully.
@rjvelazco
Copy link
Contributor Author

I think we can implement this in the new toolbar @zJaaal @kevindaviladev

@rjvelazco rjvelazco moved this from New to Gardening Day Backlog in dotCMS - Product Planning Nov 26, 2024
@github-project-automation github-project-automation bot moved this from Gardening Day Backlog to Internal QA in dotCMS - Product Planning Dec 5, 2024
@nollymar nollymar reopened this Dec 5, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Dec 5, 2024
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Dec 5, 2024
@KevinDavilaDotCMS
Copy link
Contributor

KevinDavilaDotCMS commented Dec 5, 2024

This task was closed in the resolution of: #30735

@zJaaal zJaaal self-assigned this Dec 6, 2024
@zJaaal
Copy link
Contributor

zJaaal commented Dec 6, 2024

IQA Passed

It's working as expected. I found an issue while testing this, but I don't think is related to this changes. I created a ticket to work on it #30878

DotCMS Docker Image: [dotcms/dotcms:trunk_632b9af]

Screenshot

Screen.Recording.2024-12-06.at.5.18.00.PM.mov

@zJaaal zJaaal closed this as completed Dec 6, 2024
@zJaaal zJaaal moved this from Internal QA to Done in dotCMS - Product Planning Dec 6, 2024
@zJaaal zJaaal removed their assignment Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants