Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTM: New UVE Toolbar - Implement "Bookmarks" button #30728

Closed
Tracked by #30598
KevinDavilaDotCMS opened this issue Nov 20, 2024 · 2 comments · Fixed by #30793
Closed
Tracked by #30598

FTM: New UVE Toolbar - Implement "Bookmarks" button #30728

KevinDavilaDotCMS opened this issue Nov 20, 2024 · 2 comments · Fixed by #30793

Comments

@KevinDavilaDotCMS
Copy link
Contributor

KevinDavilaDotCMS commented Nov 20, 2024

Parent Issue

#30598

Task

Implement the logic for the "Bookmarks" button in the new UVE Toolbar component. This task involves creating a new store logic for the withEditorToolbar() feature store.

This implementation involves creating a new feature store (newWithEditorToolbar) that will conditionally replace the current withEditorToolbar based on the feature flag's status like

export function withEditorToolbar() {
    if(UVE_FUTURE_TIME_MACHINE_ENABLED) {
        return newWithEditorToolbar()
    }

    return oldWithEditorToolbar();
}

Proposed Objective

Add the "Bookmarks" button logic to the new toolbar and ensure it functions correctly under the feature flag.

Acceptance Criteria

  • The "Bookmarks" button in the new toolbar must retain the functionalities of the current bookmarks button (open the "Add Bookmark" dialog and remove a bookmark).
  • The behavior of the current bookmarks button should not be affected.
Copy link

@github-project-automation github-project-automation bot moved this from In Progress to Internal QA in dotCMS - Product Planning Nov 30, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Dec 2, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Dec 2, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS removed their assignment Dec 2, 2024
@rjvelazco rjvelazco self-assigned this Dec 2, 2024
@rjvelazco
Copy link
Contributor

Passed Internal QA

  • Tested on Docker Image: [dotcms/dotcms_trunk: 910d7e2]

Video

30728-ftm-new-uve-toolbar-implement-bookmarks-button.mov

@rjvelazco rjvelazco moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Dec 2, 2024
@rjvelazco rjvelazco removed their assignment Dec 2, 2024
@nollymar nollymar moved this from QA - Backlog to Done in dotCMS - Product Planning Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants