Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary info "File link" only refers to first binary field in contentlet #28461

Open
jdcmsd opened this issue May 7, 2024 · 4 comments · May be fixed by #30684
Open

Binary info "File link" only refers to first binary field in contentlet #28461

jdcmsd opened this issue May 7, 2024 · 4 comments · May be fixed by #30684

Comments

@jdcmsd
Copy link
Contributor

jdcmsd commented May 7, 2024

Parent Issue

No response

Problem Statement

In contentlets with multiple binary fields, if you open the info pane in any given binary field, it correctly displays version path, ID path, etc., but the File Link only spits out the first Binary in the contentlet.

Steps to Reproduce

  1. Open contentlet with multiple binary fields with uploaded assets
  2. Click the "i" button to open the info pane
  3. Click the File Link
    • Result will be the first binary asset, no matter which one you had opened.
Screen.Recording.2024-05-07.at.12.02.43.PM.mov

This problem is caused by the URL path; the file link needs to include the field variable name of the binary field in question, similar to how it appears in the Version and Id paths.

The variable name is so important, we can even omit the file name itself as long as the variable name is included (note the address below).

Screenshot 2024-05-07 at 12 17 05 PM

Acceptance Criteria

File links should change to refer to their respective target images. I think it needs to change from

https://{host}/dA/{contentId}/{fileName}?{languageId}

to

https://{host}/dA/{contentId}/{binaryVarName}/{fileName}?{languageId}

dotCMS Version

dotcms-core 1.0.0-SNAPSHOT (April 30, 2024 11:38 AM)

Proposed Objective

User Experience

Proposed Priority

Priority 3 - Average

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

Copy link

github-actions bot commented Aug 7, 2024

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Aug 7, 2024
@jdcmsd jdcmsd removed the stale label Aug 7, 2024
@jdcmsd
Copy link
Contributor Author

jdcmsd commented Aug 7, 2024

Confirmed that this is still the case on the current version.

@jdotcms jdotcms self-assigned this Nov 15, 2024
@jdotcms jdotcms moved this from Gardening Day Backlog to In Progress in dotCMS - Product Planning Nov 15, 2024
@jdotcms
Copy link
Contributor

jdotcms commented Nov 15, 2024

Yeah, I was able to reproduce it, and the issue is on the resource link, fixing it

Copy link

@jdotcms jdotcms linked a pull request Nov 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Gardening Day Backlog
Development

Successfully merging a pull request may close this issue.

2 participants