Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the two octet-stream Workflow endpoints #30167

Closed
jdcmsd opened this issue Sep 27, 2024 · 2 comments · Fixed by #30168
Closed

Fixing the two octet-stream Workflow endpoints #30167

jdcmsd opened this issue Sep 27, 2024 · 2 comments · Fixed by #30168

Comments

@jdcmsd
Copy link
Contributor

jdcmsd commented Sep 27, 2024

Parent Issue

#28600

Task

Five endpoints remained unfinished in the Workflow API doc due to technical hurdles. Two of those five were return octet-stream data, and both would throw 406 errors when called from the API Playground, even with a data payload shown to work in curl.

This task is to attach a PR that fixes those two.

Proposed Objective

Documentation

Proposed Priority

Priority 3 - Average

Acceptance Criteria

POST /api/v1/workflow/actions/default/fire/{systemAction} and PATCH /api/v1/workflow/actions/default/fire/{systemAction} should both be able to return a 200 response if given a useful payload in the API Playground.

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@valentinogiardino
Copy link
Contributor

IQA PASSED

  • Tested on latest trunk trunk_324de85 - Chrome, Firefox, Edge
  • In the API Playground, both endpoints return a 200 response if given a useful payload.

Screenshots

POST /api/v1/workflow/actions/default/fire/{systemAction}

image

PATCH /api/v1/workflow/actions/default/fire/{systemAction}

image

@valentinogiardino valentinogiardino moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Oct 1, 2024
@valentinogiardino valentinogiardino removed their assignment Oct 1, 2024
@bryanboza
Copy link
Member

Fixed, tested on the latest trunk // Docker // FF

@jdcmsd jdcmsd added the LTS: Needs Backport Ticket that will be added to LTS label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants