Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Does Not Reflect Saved Default Action in Content Types Update Dialog #29765

Closed
fabrizzio-dotCMS opened this issue Aug 27, 2024 · 2 comments · Fixed by #29928
Closed

UI Does Not Reflect Saved Default Action in Content Types Update Dialog #29765

fabrizzio-dotCMS opened this issue Aug 27, 2024 · 2 comments · Fixed by #29928
Labels
Gardening Day Merged QA : Approved QA : Passed Internal Release : 24.09.21 UVE // Java21 Team : Scout Type : Defect

Comments

@fabrizzio-dotCMS
Copy link
Contributor

fabrizzio-dotCMS commented Aug 27, 2024 •
edited
Loading

Parent Issue

Problem Statement

found while testing #28684

In the Content Types Update dialog, after selecting a Default Action and clicking the "Update" button, the dialog closes as expected. However, if you reopen the dialog, it appears unchanged, as if the modifications were not saved. Despite this, a deeper investigation reveals that the changes are indeed saved. When checking the API response from the "API" button on the main Content Types edit screen, the JSON representation of the Content-Type reflects the saved changes. Additionally, if you use the CLI to download the Content Type definition, the JSON correctly shows the updates, including the changes to the Default Action. This behavior suggests that the UI is ignoring the presence of the systemActionMappings attribute in the server's response, leading to the false impression that the changes were not applied.

Steps to Reproduce

  1. Open the Content Types Edit dialog.
  2. Select a Default Action.
  3. Click the "Update" button to save changes.
  4. Reopen the Content Types Edit dialog.
  5. Observe that the dialog appears as it was before the update, without reflecting the saved changes.
  6. Check the API response via the "API" button or use the CLI to download the Content Type definition to see that the changes were actually saved in the JSON.
Screen.Recording.2024-08-27.at.12.38.36.PM.mov

Acceptance Criteria

The Dialog must show accurate saved data

dotCMS Version

current Trunk. it can also be reproduced in demo

Proposed Objective

User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@fabrizzio-dotCMS fabrizzio-dotCMS mentioned this issue Aug 27, 2024
Closed
@nollymar nollymar moved this from New to Gardening Day Backlog in dotCMS - Product Planning Aug 28, 2024
@valentinogiardino valentinogiardino self-assigned this Sep 6, 2024
@valentinogiardino valentinogiardino moved this from Gardening Day Backlog to QA - In Progress in dotCMS - Product Planning Sep 6, 2024
@valentinogiardino valentinogiardino moved this from QA - In Progress to In Progress in dotCMS - Product Planning Sep 6, 2024
@valentinogiardino valentinogiardino mentioned this issue Sep 9, 2024
Merged
3 tasks
@valentinogiardino valentinogiardino moved this from In Progress to In Review in dotCMS - Product Planning Sep 9, 2024
@valentinogiardino valentinogiardino linked a pull request Sep 9, 2024 that will close this issue
fix(Content Types Edit Dialog) Workflow actions dropdown #29928
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 10, 2024
@valentinogiardino
fix(Content Types Edit Dialog) Workflow actions dropdown (#29928)
12934b5 
### Proposed Changes
* Emit the initial value of the form in `workflowsSelected$` observable.
* Add a check to ensure the workflow actions dropdown exists before
attempting to clear it.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Additional Info
This PR fixes:
1. #29765
2. #29762

### Screenshots
#### Before


![image](https://github.com/user-attachments/assets/f9851368-7479-4a9c-a354-77c82093a0c9)
#### After


https://github.com/user-attachments/assets/766cb82a-763f-4d57-8325-14eaba622455
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Sep 10, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Sep 10, 2024
@valentinogiardino valentinogiardino removed their assignment Sep 10, 2024
@valentinogiardino valentinogiardino moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Sep 10, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this Sep 13, 2024
@fabrizzio-dotCMS
Copy link
Contributor Author

Looks good to me

@fabrizzio-dotCMS fabrizzio-dotCMS removed their assignment Sep 13, 2024
@fabrizzio-dotCMS fabrizzio-dotCMS moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Sep 13, 2024
dsolistorres pushed a commit that referenced this issue Sep 18, 2024
@valentinogiardino @dsolistorres
fix(Content Types Edit Dialog) Workflow actions dropdown (#29928)
b822de8 
### Proposed Changes
* Emit the initial value of the form in `workflowsSelected$` observable.
* Add a check to ensure the workflow actions dropdown exists before
attempting to clear it.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Additional Info
This PR fixes:
1. #29765
2. #29762

### Screenshots
#### Before


![image](https://github.com/user-attachments/assets/f9851368-7479-4a9c-a354-77c82093a0c9)
#### After


https://github.com/user-attachments/assets/766cb82a-763f-4d57-8325-14eaba622455
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_5b70657, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to QA - Rejected in dotCMS - Product Planning Sep 19, 2024
@josemejias11 josemejias11 moved this from QA - Rejected to Done in dotCMS - Product Planning Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Sep 23, 2024
@nollymar nollymar moved this from Internal QA to Done in dotCMS - Product Planning Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Gardening Day Merged QA : Approved QA : Passed Internal Release : 24.09.21 UVE // Java21 Team : Scout Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Content Types Edit Dialog) Workflow actions dropdown dotCMS/core
4 participants
@nollymar @fabrizzio-dotCMS @valentinogiardino @josemejias11