Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimeNG v17: Alignment of pagination #29673

Closed
Tracked by #29058
nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29722
Closed
Tracked by #29058

PrimeNG v17: Alignment of pagination #29673

nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29722
Assignees
@hmoreras
Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Aug 20, 2024 •
edited
Loading

Parent Issue

#29058

Issues

  • In general in the platform the pagination should be aligned to the end, but with PrimeNg v17 upgrade some components shows the alignment of the pagination centered.

Screenshots

v15 v17
Screenshot 2024-08-09 at 10 30 05 AM Screenshot 2024-08-09 at 10 29 50 AM
Screenshot 2024-08-09 at 10 31 08 AM Screenshot 2024-08-09 at 10 31 00 AM

Additional info

The branch for this card must be epic-primeng-upgrade, and the PR must target that branch.
@nicobytes nicobytes mentioned this issue Aug 20, 2024
Closed
@nicobytes nicobytes changed the title PrimeNG v17: Pagination issues PrimeNG v17: Alignment of pagination Aug 20, 2024
@nicobytes nicobytes moved this from New to Current Sprint Backlog in dotCMS - Product Planning Aug 20, 2024
@hmoreras hmoreras self-assigned this Aug 22, 2024
@hmoreras hmoreras moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Aug 22, 2024
@hmoreras hmoreras moved this from In Progress to In Review in dotCMS - Product Planning Aug 22, 2024
nicobytes pushed a commit that referenced this issue Aug 23, 2024
@hmoreras
mplementation(PrimeNG-17): #29673 Alignment of pagination (#29722)
81e1a57 
### Proposed Changes
* The `justify-content` rule has been overwritten by the PrimeNG theme,
but because of the [CSS layer](https://primeng.org/guides/csslayer)
implemented in V17, the custom styles now take precedence.
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 23, 2024
@nicobytes nicobytes moved this from Internal QA to Done in dotCMS - Product Planning Aug 23, 2024
@hmoreras hmoreras linked a pull request Aug 23, 2024 that will close this issue
mplementation(PrimeNG-17): #29673 Alignment of pagination #29722
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmoreras hmoreras

Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mplementation(PrimeNG-17): #29673 Alignment of pagination dotCMS/core
2 participants
@nicobytes @hmoreras