Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimeNG v17: Fix p-dataview breaking change #29657

Closed
Tracked by #29058
nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29658
Closed
Tracked by #29058

PrimeNG v17: Fix p-dataview breaking change #29657

nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29658
Assignees
@nicobytes
Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Aug 20, 2024 •
edited
Loading

Parent Issue

#29058

Goal

There is a breaking change with p-dataview in PrimeNG v17

gridItem and listItem templates are deprecated and will removed in the future, use list and grid templates instead.

Screenshots

v15 v17
Screenshot 2024-08-20 at 9 25 49 AM Screenshot 2024-08-20 at 9 25 34 AM
Screenshot 2024-08-09 at 6 39 25 PM Screenshot 2024-08-09 at 6 10 06 PM
DotCMS/ThemeSelector DotCMS/ThemeSelector
Screenshot 2024-08-20 at 11 25 41 AM Screenshot 2024-08-20 at 11 25 34 AM
Screenshot 2024-08-20 at 5 13 29 PM Screenshot 2024-08-20 at 5 11 52 PM
Screenshot 2024-08-20 at 5 13 38 PM Screenshot 2024-08-20 at 5 12 13 PM

Additional info

The branch for this card must be epic-primeng-upgrade, and the PR must target that branch.

Refs
@nicobytes nicobytes mentioned this issue Aug 20, 2024
Closed
@nicobytes nicobytes self-assigned this Aug 20, 2024
@nicobytes nicobytes moved this from New to In Progress in dotCMS - Product Planning Aug 20, 2024
@nicobytes nicobytes mentioned this issue Aug 20, 2024
Merged
3 tasks
@nicobytes nicobytes linked a pull request Aug 20, 2024 that will close this issue
PrimeNG v17: Fix p-dataview breaking change #29658
Merged
3 tasks
@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Aug 20, 2024
nicobytes added a commit that referenced this issue Aug 21, 2024
@nicobytes
PrimeNG v17: Fix p-dataview breaking change (#29658)
6810af6 
### Parent Issue
#29657

### Proposed Changes
* Fix error with breaking change by PrimeNg V17  upgrade

> gridItem and listItem templates are deprecated and will removed in the
future, use list and grid templates instead.

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Screenshots
v15             |  v17
:-------------------------:|:-------------------------:
![Screenshot 2024-08-20 at 9 25
49 AM](https://github.com/user-attachments/assets/b0c302b6-d9f4-4a52-afc9-203c6da9fba3)
| ![Screenshot 2024-08-20 at 9 25
34 AM](https://github.com/user-attachments/assets/a12c2e74-fe1a-499b-a2e7-0a16679c02b4)
![Screenshot 2024-08-09 at 6 39
25 PM](https://github.com/user-attachments/assets/f5996809-2f38-4d77-8de6-6f7edfe8004c)
| ![Screenshot 2024-08-09 at 6 10
06 PM](https://github.com/user-attachments/assets/1da9b0d7-82c1-41ec-a56c-4d1da87646d3)
DotCMS/ThemeSelector | DotCMS/ThemeSelector
![Screenshot 2024-08-20 at 11 25
41 AM](https://github.com/user-attachments/assets/c622871a-728d-4dba-a58f-cb210c4eaed2)
| ![Screenshot 2024-08-20 at 11 25
34 AM](https://github.com/user-attachments/assets/7e0e9c5b-9131-4afb-9ea6-13d824312087)
![Screenshot 2024-08-20 at 5 13
29 PM](https://github.com/user-attachments/assets/09aec08e-c638-4a08-9b12-5559d0c4faf1)
| ![Screenshot 2024-08-20 at 5 11
52 PM](https://github.com/user-attachments/assets/6f886b52-ffaf-4a3d-beaa-02dedc0eaf0e)
![Screenshot 2024-08-20 at 5 13
38 PM](https://github.com/user-attachments/assets/1816f4f0-4d62-4390-b613-938390a9eba0)
| ![Screenshot 2024-08-20 at 5 12
13 PM](https://github.com/user-attachments/assets/ca9baac9-98fb-4f1b-a8e9-5ce1bcde4c27)
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 21, 2024
@nicobytes nicobytes moved this from Internal QA to Done in dotCMS - Product Planning Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicobytes nicobytes

Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PrimeNG v17: Fix p-dataview breaking change dotCMS/core
2 participants
@nicobytes @hmoreras