Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change category selection from PrimeNG sidebar to dialog #29563

Closed
Tracked by #28493
oidacra opened this issue Aug 13, 2024 · 2 comments · Fixed by #29770
Closed
Tracked by #28493

Change category selection from PrimeNG sidebar to dialog #29563

oidacra opened this issue Aug 13, 2024 · 2 comments · Fixed by #29770

Comments

@oidacra
Copy link
Member

oidacra commented Aug 13, 2024

Parent Issue

#28493

Task

Change the category selection component from a PrimeNG sidebar to a PrimeNG dialog. This task involves modifying the existing UI to improve the user experience for category selection.

Proposed Objective

Technical User Experience

Proposed Priority

Priority 3 - Average

Acceptance Criteria

  1. Category selection is displayed in a PrimeNG dialog instead of a sidebar
  2. A "Cancel" button is added to the dialog, which closes it when clicked
  3. An "Apply" button is added to the dialog, which applies the selection to the input when clicked
  4. A close (X) icon is added to the dialog header
  5. The dialog closes when the ESC key is pressed
  6. The dialog NOT closes when clicked outside of it (on the overlay)
  7. The new implementation is tested and working as expected across all relevant pages/components
  8. By default, the dialog has 1 full column of categories and 2 empty (the sidebar has total 4)

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

FIGMA (https://www.figma.com/design/YMTdSO5gKf18rc1pCCv1jN/Edit-Contentlet?node-id=3795-86963&t=xOJCvxGRqJH8HShn-1)

Assumptions & Initiation Needs

  • Current implementation uses PrimeNG sidebar component
  • No major changes to the backend or data structure are required for this UI change

Quality Assurance Notes & Workarounds

  • Opening and closing the dialog using all available methods (buttons, ESC, overlay click)
  • Selecting categories and applying/canceling the selection

Sub-Tasks & Estimates

No response

@oidacra oidacra moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Aug 13, 2024
@dsilvam dsilvam removed the Triage label Aug 21, 2024
@hmoreras hmoreras self-assigned this Aug 23, 2024
@hmoreras hmoreras moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Aug 23, 2024
@hmoreras hmoreras moved this from In Progress to In Review in dotCMS - Product Planning Aug 28, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
…m PrimeNG sidebar to dialog (#29770)

### Proposed Changes
* Category selection is displayed in a PrimeNG dialog instead of a
sidebar



### Screenshots

Before 


https://github.com/user-attachments/assets/e0549b6c-4992-4e1a-b5cb-fd4125566930


After 


https://github.com/user-attachments/assets/f992c914-5119-4923-9c78-c803a42daa48
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 29, 2024
@dsilvam dsilvam assigned dsilvam and unassigned hmoreras Sep 2, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Sep 2, 2024

Passed Internal QA: The selection for the category field was moved to a dialog and all the checks from the description are in place.

Image

@dsilvam dsilvam moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Sep 2, 2024
@josemejias11 josemejias11 moved this from QA - Backlog to Done in dotCMS - Product Planning Sep 3, 2024
@josemejias11 josemejias11 moved this from Done to QA - In Progress in dotCMS - Product Planning Sep 3, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on master_b295876_SNAPSHOT, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants